fix(finance): maskedNumber has incorrect defaults #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2494 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 2779 2779
Lines 249273 249273
Branches 1084 1084
=======================================
+ Hits 248230 248232 +2
+ Misses 1015 1013 -2
Partials 28 28
|
xDivisionByZerox
previously approved these changes
Oct 22, 2023
|
Given that the defaults were accidentally changed during a method rename and we didn't catch that, suggests there should be a test for that? e.g. check that maskedNumber() with no params includes (... ) |
Done |
matthewmayer
previously approved these changes
Oct 27, 2023
xDivisionByZerox
previously approved these changes
Oct 27, 2023
ST-DDT
dismissed stale reviews from xDivisionByZerox and matthewmayer
via
ac10f9a
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
xDivisionByZerox
previously approved these changes
Oct 27, 2023
xDivisionByZerox
approved these changes
Oct 31, 2023
matthewmayer
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect defaults introduced in #2055
See also:
Alternative solution:
Additional suggestion:
Deprecate the method entirely (because it is probably more useful if done like this by the user:
which converts
DE241358431563434532toDE24**************32We should probably document that somewhere in our docs too, although I assume they should already have something similar in their code somewhere.